[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

Thanks for taking a look at this!



================
Comment at: clang/test/Sema/implicit-decl.c:2
+// RUN: %clang_cc1 %s -verify=expected,implicit -fsyntax-only -Werror=implicit-function-declaration
+// RUN: %clang_cc1 %s -verify -fsyntax-only -Wno-implicit-function-declaration
+
----------------
I probably wouldn't bother testing this - presumably we don't test the -Wno- variant of every warning, given that it's implemented in a generic fashion?

If this is removed, I expect the verifier prefixes don't need to be changed?


================
Comment at: clang/test/Sema/vecshift.c:3-4
+// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify=expected,vecelemsize %s
+// RUN: %clang_cc1 -fsyntax-only -DERR -verify %s -Wno-vec-elem-size
+// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify %s -Wno-vec-elem-size
 
----------------
The previous version of the test had this without -DERR, right? Why the change here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90874/new/

https://reviews.llvm.org/D90874