[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 5 14:29:24 PST 2020


dexonsmith added inline comments.


================
Comment at: clang/lib/Frontend/ASTUnit.cpp:1135-1141
   // Ensure that Clang has a FileManager with the right VFS, which may have
   // changed above in AddImplicitPreamble.  If VFS is nullptr, rely on
   // createFileManager to create one.
   if (VFS && FileMgr && &FileMgr->getVirtualFileSystem() == VFS)
     Clang->setFileManager(&*FileMgr);
   else
     FileMgr = Clang->createFileManager(std::move(VFS));
----------------
Here's where the FileManager was already set up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90888/new/

https://reviews.llvm.org/D90888



More information about the cfe-commits mailing list