[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 5 13:58:50 PST 2020
rnk added a comment.
Given that only three tests fail when the `nossp` attribute gets added from `-cc1` with no stack protector, I think it's reasonable to add it and skip adding the extra enum.
I think it would be weird if we LTO'd together three kinds of objects (sp on, sp off, sp unspecified) and the inliner was able to inline some of them. It seems better to decide that unspecified either means on or off, depending on the target defaults.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90194/new/
https://reviews.llvm.org/D90194
More information about the cfe-commits
mailing list