[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 5 11:32:09 PST 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some tiny nits!



================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:172
   SmallString<64> StyleString;
+  auto Styles = MainFileStyle->getStyles();
   for (size_t I = 0; I < SK_Count; ++I) {
----------------
Don't use `auto` when the type isn't spelled out in the initialization.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-multiple-styles.cpp:63
+// CHECK-MESSAGES-SHARED:   global-style2/header.h:7:52: warning: invalid case style for parameter 'argv'
\ No newline at end of file

----------------
Should end the newline back to the end of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90832/new/

https://reviews.llvm.org/D90832



More information about the cfe-commits mailing list