[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

Melanie Blower via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 5 05:22:43 PST 2020


mibintc added a comment.

In D90714#2374913 <https://reviews.llvm.org/D90714#2374913>, @dblaikie wrote:

> Since the same code is used to mangle all these things, probably just test one of them?
>
> Could use macros to stamp out longer names without having to write them out manually?

Not sure what technique to use to stamp out longer names, I tried using token pasting but that doesn't work because the tokens aren't macro expanded before pasting?  I like the test source I added because it came from a program seen in the wild, and it demonstrates that reasonable length identifiers can generate enormous mangled names.
#define X50 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#define X45 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#define X100 X50 ## X50  // X100 is X50X50


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90714/new/

https://reviews.llvm.org/D90714



More information about the cfe-commits mailing list