[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

Tim Northover via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 5 01:49:58 PST 2020


t.p.northover added a comment.

With current CodeGen by the time you reach the trap you have no idea what came before so I think you'd still need a separate trap instruction per failure kind. So the Clang and generic LLVM side would be unaffected.

I suppose on X86 it could save a few bytes in .text and so maybe icache (though again we're talking about roughly 50% bloat for enabling UBSAN at all so this is kind of lost in the noise). On the whole I'm not a fan of inventing a new entirely separate scheme for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89959/new/

https://reviews.llvm.org/D89959



More information about the cfe-commits mailing list