[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 10:42:13 PST 2020


aeubanks added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFTargetMachine.cpp:129
                                                     bool DebugPassManager) {
   PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) {
     FunctionPassManager FPM(DebugPassManager);
----------------
ychen wrote:
> Maybe I missed something. Except for PipelineStartEPCallback, all the other EP callbacks already take `OptimizationLevel` as input, do we only need to extend PipelineStartEPCallback to also take `OptimizationLevel` as input?
You're right, I didn't realize that. https://reviews.llvm.org/D90777 for that approach


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90486/new/

https://reviews.llvm.org/D90486



More information about the cfe-commits mailing list