[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

Wed Nov 4 05:23:28 PST 2020

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:115
   LINK_LIBS
+  clangdRemoteIndex
   clangdSupport
----------------
kadircet wrote:
> kbobyrev wrote:
> > If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link `clangd` itself to `clangdRemoteIndex` anymore (in `tool/CMakeLists.txt`).
> All of the libraries linked to clangDeamon are explicitly being linked again to clangd. Even though the ones coming from clang and clangTooling are marked as private here, others like clangdSupport and clangTidy are linked with "default" (whatever that means) visibility. Hence I kept the linking on the clangd side as well.
> 
> I suppose moving these to PRIVATE libraries and keeping the extra linking in ClangdMain is the more consistent thing. As ClangdMain still calls `remote::getClient`. Let me know if you disagree or I am missing something.
I see, makes sense, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90746/new/

https://reviews.llvm.org/D90746