[clang-tools-extra] 05e0a8e - [clangd] Fix missing override warnings in remote-index client

Kadir Cetinkaya via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 12:53:38 PST 2020


Author: Kadir Cetinkaya
Date: 2020-11-03T21:46:44+01:00
New Revision: 05e0a8e519fd7dd73141b58a1a479a84a5ac1014

URL: https://github.com/llvm/llvm-project/commit/05e0a8e519fd7dd73141b58a1a479a84a5ac1014
DIFF: https://github.com/llvm/llvm-project/commit/05e0a8e519fd7dd73141b58a1a479a84a5ac1014.diff

LOG: [clangd] Fix missing override warnings in remote-index client

Added: 
    

Modified: 
    clang-tools-extra/clangd/index/remote/Client.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/index/remote/Client.cpp b/clang-tools-extra/clangd/index/remote/Client.cpp
index ff6f1b2898d7..ef5c6ce430f6 100644
--- a/clang-tools-extra/clangd/index/remote/Client.cpp
+++ b/clang-tools-extra/clangd/index/remote/Client.cpp
@@ -84,26 +84,28 @@ class IndexClient : public clangd::SymbolIndex {
   }
 
   void lookup(const clangd::LookupRequest &Request,
-              llvm::function_ref<void(const clangd::Symbol &)> Callback) const {
+              llvm::function_ref<void(const clangd::Symbol &)> Callback)
+      const override {
     streamRPC(Request, &remote::v1::SymbolIndex::Stub::Lookup, Callback);
   }
 
-  bool
-  fuzzyFind(const clangd::FuzzyFindRequest &Request,
-            llvm::function_ref<void(const clangd::Symbol &)> Callback) const {
+  bool fuzzyFind(const clangd::FuzzyFindRequest &Request,
+                 llvm::function_ref<void(const clangd::Symbol &)> Callback)
+      const override {
     return streamRPC(Request, &remote::v1::SymbolIndex::Stub::FuzzyFind,
                      Callback);
   }
 
-  bool refs(const clangd::RefsRequest &Request,
-            llvm::function_ref<void(const clangd::Ref &)> Callback) const {
+  bool
+  refs(const clangd::RefsRequest &Request,
+       llvm::function_ref<void(const clangd::Ref &)> Callback) const override {
     return streamRPC(Request, &remote::v1::SymbolIndex::Stub::Refs, Callback);
   }
 
   void
   relations(const clangd::RelationsRequest &Request,
             llvm::function_ref<void(const SymbolID &, const clangd::Symbol &)>
-                Callback) const {
+                Callback) const override {
     streamRPC(Request, &remote::v1::SymbolIndex::Stub::Relations,
               // Unpack protobuf Relation.
               [&](std::pair<SymbolID, clangd::Symbol> SubjectAndObject) {
@@ -113,7 +115,7 @@ class IndexClient : public clangd::SymbolIndex {
 
   // IndexClient does not take any space since the data is stored on the
   // server.
-  size_t estimateMemoryUsage() const { return 0; }
+  size_t estimateMemoryUsage() const override { return 0; }
 
 private:
   std::unique_ptr<remote::v1::SymbolIndex::Stub> Stub;


        


More information about the cfe-commits mailing list