[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I think this LGTM aside from a few minor nits. Thank you for working on this!



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-sig30-c.rst:12-14
+This check corresponds to the CERT C Coding Standard rule
+`SIG30-C. Call only asynchronous-safe functions within signal handlers
+<https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers>`_.
----------------
I think this bit about the CERT link should move into the main checker documentation (if only because the alias documentation will redirect to the main documentation after five seconds).


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-sig30-c.rst:15
+<https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers>`_.
+The check handles only C code.
----------------
Same for the C-only nature of the check.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/signal.h:20
+typedef void (*sighandler_t)(int);
+sighandler_t signal(int signum, sighandler_t handler);
+
----------------
Might as well drop the parameter names here as well.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stdlib.h:13-14
+void abort(void);
+void _Exit(int __status);
+void quick_exit(int __status);
+
----------------
Might as well drop the parameter names here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87449/new/

https://reviews.llvm.org/D87449