[PATCH] D90409: [HIP] Math Headers to use type promotion

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 10:45:46 PST 2020


jlebar added a comment.

> LGTM. I think the change would make sense for CUDA, too. @jlebar - WDYT?

I agree that the C and C++ standard libraries should behave the same in CUDA mode and host mode!

But if doing so would make our behavior different than nvcc's, maybe we could emit a warning or something?  Like, "this code you wrote maybe for nvcc is going to do something different with clang."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90409/new/

https://reviews.llvm.org/D90409



More information about the cfe-commits mailing list