[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

Tue Nov 3 09:00:37 PST 2020

erichkeane added a comment.

In D90634#2371436 <https://reviews.llvm.org/D90634#2371436>, @aaron.ballman wrote:

> This LGTM but you should wait a day or so in case @rjmccall has opinions.

Thanks, will do!

================
Comment at: clang/lib/Sema/SemaLambda.cpp:1281
+  /// Additionally, we are ensuring that the default-free/default-member and
+  /// call-operator calling convention are generated as well.
+  if (S.getLangOpts().MSVCCompat) {
----------------
aaron.ballman wrote:
> Should we call out that one of the existing member functions is likely to be `thiscall` which means we'll generate a version of the operator for that calling convention even though MSVC doesn't, but we want to do this because users can explicitly write the CC on the lambda (unlike in MSVC)? (I'm worried that lack of mention about `thiscall` may look like a bug to someone a few years down the line.)
Can do!  I put it in the commit message as well, 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90634/new/

https://reviews.llvm.org/D90634