[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 08:37:52 PST 2020


aaron.ballman added inline comments.


================
Comment at: clang/lib/Sema/SemaLambda.cpp:1282
+  /// call-operator calling convention are generated as well.
+  /// NOTE: We intentionally generate a 'thiscall' (on Win32) despite MSVC not.
+  /// We do this in order to ensure that someone who intentionally places
----------------
If we're intentionally generating it, should it be listed explicitly in `Convs` below? (If not, then perhaps change the comment somewhat to "We intentionally generate a 'thiscall' (on Win32) implicitly from the default member call's calling convention..."?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90634/new/

https://reviews.llvm.org/D90634



More information about the cfe-commits mailing list