[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Sema/SemaLambda.cpp:1281
+  /// Additionally, we are ensuring that the default-free/default-member and
+  /// call-operator calling convention are generated as well.
+  if (S.getLangOpts().MSVCCompat) {
----------------
Should we call out that one of the existing member functions is likely to be `thiscall` which means we'll generate a version of the operator for that calling convention even though MSVC doesn't, but we want to do this because users can explicitly write the CC on the lambda (unlike in MSVC)? (I'm worried that lack of mention about `thiscall` may look like a bug to someone a few years down the line.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90634/new/

https://reviews.llvm.org/D90634