[PATCH] D88859: APINotes: add APINotesYAMLCompiler

Tue Nov 3 02:35:25 PST 2020

martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.

Looks good to me now! Thanks for addressing my concerns.

================
Comment at: clang/tools/apinotes-test/APINotesTest.cpp:15
+
+static llvm::cl::list<std::string>
+APINotes(llvm::cl::Positional, llvm::cl::desc("[<apinotes> ...]"),
----------------
We still have: `clang-format: please reformat the code`. (Mabe you already know, but if you use [[ https://secure.phabricator.com/book/phabricator/article/arcanist/ | arc ]] then all these formatting issues are handled automatically and it will upload a linted patch to Phabricator.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88859/new/

https://reviews.llvm.org/D88859