[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

John Paul Adrian Glaubitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 14:02:30 PST 2020


glaubitz added a comment.

In D52050#2369581 <https://reviews.llvm.org/D52050#2369581>, @dschuff wrote:

> Can you upload the diff with full context (e.g. use `diff -U 9999` or use arcanist to upload)?
>
> I'm a bit confused; the commit message talks about X32 being a separate architecture, but you're not adding any new architecture triples here (it still uses x86_64 as the architecture and selects the ABI via the environment). AFAICS what really changes is that the structure of the include and lib directories is now multi-arch style with the x32 headers alongside the x86_64 base headers?

Updated diff coming in a bit.

As for the term architecture: It's a separate architecture in Debian which can also mean just a different ABI. In Debian terms, an architecture can be a different ABI, different real architecture or different kernel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52050/new/

https://reviews.llvm.org/D52050



More information about the cfe-commits mailing list