[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 13:30:00 PST 2020


aaronpuchert added inline comments.


================
Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:158
+}
+
 }  // end namespace ScopeTest
----------------
aaron.ballman wrote:
> Given that this is touching on declaration contexts, it would also be good to have some tests checking for differences between declaration contexts (like out-of-line method definitions)
Isn't there a semantic and a lexical declaration context, and aren't we consistently using the semantic context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87194/new/

https://reviews.llvm.org/D87194



More information about the cfe-commits mailing list