[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

Just a few minor nits. I'll leave the approving to the other reviewers.



================
Comment at: clang/lib/AST/TextNodeDumper.cpp:1828
+  if (D->isNested())
+    OS << " nested";
   if (!D->isOriginalNamespace())
----------------
Can you also modify `JSONNodeDumper::VisitNamespaceDecl` ?


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11169
+        &PP.getIdentifierTable().get("std"),
+        /*PrevDecl=*/nullptr, false);
     getStdNamespace()->setImplicit(true);
----------------
Please change `false` to `/*Nested=*/false`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90568/new/

https://reviews.llvm.org/D90568