[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 12:40:03 PST 2020


mstorsjo updated this revision to Diff 302374.
mstorsjo added a comment.

Just checking `_MSC_VER` instead of checking `SANITIZER_WINDOWS && !__MINGW32__`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90571/new/

https://reviews.llvm.org/D90571

Files:
  compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp
  compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp


Index: compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp
===================================================================
--- compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp
+++ compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp
@@ -12,7 +12,7 @@
 
 #include "sanitizer_common/sanitizer_platform.h"
 #include "ubsan_platform.h"
-#if CAN_SANITIZE_UB && SANITIZER_WINDOWS
+#if CAN_SANITIZE_UB && defined(_MSC_VER)
 #include "ubsan_type_hash.h"
 
 #include "sanitizer_common/sanitizer_common.h"
Index: compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp
===================================================================
--- compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp
+++ compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp
@@ -12,7 +12,7 @@
 
 #include "sanitizer_common/sanitizer_platform.h"
 #include "ubsan_platform.h"
-#if CAN_SANITIZE_UB && !SANITIZER_WINDOWS
+#if CAN_SANITIZE_UB && !defined(_MSC_VER)
 #include "ubsan_type_hash.h"
 
 #include "sanitizer_common/sanitizer_common.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90571.302374.patch
Type: text/x-patch
Size: 982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201102/c31496e7/attachment.bin>


More information about the cfe-commits mailing list