[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 08:09:02 PST 2020


vsk added a comment.

I might've missed it, but the debug location merging behavior could use a test. Here's one way to write it: https://godbolt.org/z/Yb9PY9.

In `@_Z13keep_locationPi`, the !dbg attachment on the trap should match `!DILocation(line: 1`. In `@_Z15merge_locationsPi`, the attachment should match `!DILocation(line: 0` (it currently incorrectly points to line 4).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89959/new/

https://reviews.llvm.org/D89959



More information about the cfe-commits mailing list