[PATCH] D90291: [clangd] Add lit tests for remote index

[Hans Wennborg via Phabricator via cfe-commits]

hans added inline comments.


================
Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11
 config.host_triple = "@LLVM_HOST_TRIPLE@"
+config.python_executable = "@Python3_EXECUTABLE@"
 
----------------
kadircet wrote:
> hans wrote:
> > Could this use `PYTHON_EXECUTABLE` instead? I see other tests using that, and Python3_EXECUTABLE might not always be set.
> i was checking llvm's [lit.site.cfg.py.in](http://github.com//llvm/llvm-project/tree/master/llvm/test/lit.site.cfg.py.in) for reference and it was using python3 too.
> 
> any specific reasons for using PYTHON_EXECUTABLE instead of python3? I can't say this was a strong preference, but the python script included might not be python2 compliant, hence the need for 3.
> 
> If there is a compelling reason for using a possibly python2 executable, we can try to make the script both 2 and 3 compliant.
> i was checking llvm's lit.site.cfg.py.in for reference and it was using python3 too.

Oh interesting, I hadn't seen that. Well then using it here too makes sense I suppose. Sorry for the noise :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90291/new/

https://reviews.llvm.org/D90291