[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 06:14:19 PST 2020


kadircet added a comment.

In D90526#2367782 <https://reviews.llvm.org/D90526#2367782>, @sammccall wrote:

> So I can't remember anymore why I put this as an enum `-log=public` rather than an independent switch `-log-public` or so that could combine with any log level.
> Sounds like the latter would be better?

Agreed.

> Manually insert it into the format string. After thinking about it I came to the conclusion there just aren't that many places where we need to log things publicly. I expect to basically not have any visibility inside most requests except the error patterns.

SG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90526/new/

https://reviews.llvm.org/D90526



More information about the cfe-commits mailing list