[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 05:32:00 PST 2020


sammccall added a comment.

This doesn't feel quite right to me - we're going to need to get PP conditional regions, include blocks etc from the ParsedAST (they're not in ASTContext).
My sense is that we'll need a fairly random subset of ParsedAST, and so ParsedAST is a reasonable abstraction unless it's hard to produce for tests. But it isn't!

What's the motivation for this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90588/new/

https://reviews.llvm.org/D90588



More information about the cfe-commits mailing list