[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 2 03:12:30 PST 2020


CJ-Johnson marked an inline comment as done.
CJ-Johnson added a comment.

In D17993#2367447 <https://reviews.llvm.org/D17993#2367447>, @rsmith wrote:

> Thanks! We should also have a test for the behavior when targeting the MS ABI, where we sometimes don't emit the `nonnull dereferenceable` because the "`this`" pointer might actually point outside the object, but otherwise I think this is ready to go.
>
> Please can you also put together a patch for the release notes? This seems worth mentioning there.

Done and done. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17993/new/

https://reviews.llvm.org/D17993



More information about the cfe-commits mailing list