[PATCH] D90397: [clangd] Value initialize SymbolIDs

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolID.h:58
+  bool isNull() const { return HashValue != std::array<uint8_t, RawSize>{}; }
+  operator bool() const { return isNull(); }
+
----------------
sammccall wrote:
> sammccall wrote:
> > nit: I think you want this to be explicit. Note that if(x) **will** perform an explicit cast if needed
> this should be `!isNull()`!
oopsy, should've ran tests :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90397/new/

https://reviews.llvm.org/D90397