[PATCH] D90526: [clangd] Add -log=public to redact all request info from index server logs

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Thanks for figuring this one out!

I think the final result looks pretty good, I especially loved only disabling when there's a request in question.
My only hesitation is around logging all severities when we are outside a request, I suppose it shouldn't cause too much trouble but we sometimes end up logging too much in verbose mode and I am afraid of this hindering the server performance at random intervals (e.g. when it loads a new index). But this is just speculation. I suppose we can think about this when it happens. Also maybe we should not be logging that much instead :D

In addition to that it could be nice to see how the `public` tagging will happen. Are you planning to have a custom endpoint for it, or should the user manually insert it into format string? Both are fine by me, the latter might even make it less error-prone for accidental logging at the cost of misspells and spreading the string across the codebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90526/new/

https://reviews.llvm.org/D90526