[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:78
+    llvm::cl::desc("Delay between index hot reload checks (in seconds)"),
+    llvm::cl::init(90),
+    llvm::cl::Hidden,
----------------
this was 30 before. not that it matters.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:79
+    llvm::cl::init(90),
+    llvm::cl::Hidden,
+};
----------------
i think this might be useful in general, as servers will have different pull frequency for newer index. so maybe make it non-hidden.


================
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:35
       'clangd-index-server', '--server-address=' + server_address,
-      args.index_file, args.project_root
+      '--hot-reload-frequency=3', args.index_file, args.project_root
   ],
----------------
let's set it to 1. clangd tests already takes about 3-4 seconds to run on (our) workstations. it feels like this might end up increasing the test latency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90587/new/

https://reviews.llvm.org/D90587