[PATCH] D90291: [clangd] Add lit tests for remote index
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 1 23:41:08 PST 2020
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:51
+ os.kill(index_server_process.pid, 9)
> can we rather use `signal.SIGXXX` here instead of `9` ?
> Also rather than kill, SIGINT might be more applicable. https://docs.python.org/3/library/signal.html#signal.SIGKILL claims sigkill is not available on windows.
The problem with `SIGINT` is that it needs to wait for the hot reload sync to finish :) I'll add a patch to modify the frequency via CLI to avoid long test terminaiton.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits