[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 1 23:37:33 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d15a28a853d: [clangd] Fix ParsedASTTest.TopLevelDecls test. (authored by ilya-golovenko, committed by hokein).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90384/new/

https://reviews.llvm.org/D90384

Files:
  clang-tools-extra/clangd/unittests/ParsedASTTests.cpp


Index: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/ParsedASTTests.cpp
+++ clang-tools-extra/clangd/unittests/ParsedASTTests.cpp
@@ -59,7 +59,7 @@
 
 MATCHER_P(DeclKind, Kind, "") {
   if (NamedDecl *ND = dyn_cast<NamedDecl>(arg))
-    if (ND->getDeclKindName() == Kind)
+    if (ND->getDeclKindName() == llvm::StringRef(Kind))
       return true;
   if (auto *Stream = result_listener->stream()) {
     llvm::raw_os_ostream OS(*Stream);
@@ -104,8 +104,7 @@
          std::tie(Expected.HashLine, Expected.Written);
 }
 
-// FIXME: figure out why it fails on clang-ppc64le-rhel buildbot.
-TEST(ParsedASTTest, DISABLED_TopLevelDecls) {
+TEST(ParsedASTTest, TopLevelDecls) {
   TestTU TU;
   TU.HeaderCode = R"(
     int header1();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90384.302212.patch
Type: text/x-patch
Size: 845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201102/3dafb838/attachment.bin>


More information about the cfe-commits mailing list