[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

[Mark Nauwelaerts via Phabricator via cfe-commits]

mnauw added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:4481
   Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign;
+  Style.PenaltyBreakBeforeFirstCallParameter = 0;
   Style.AlignOperands = FormatStyle::OAS_DontAlign;
----------------
MyDeveloperDay wrote:
> Why do you need these? what is the default value of this as set in the LLVM style?
The default value in the LLVM style is 19.  However, the fragment of code in TokenAnnotator.cpp basically hard-codes this to 0 (in case of BAS_DontAlign; see that part).  Since that part is now changed to really use PenaltyBreakBeforeFirstCallParameter style option, the latter is set to 0 in these cases to retain the original behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90533/new/

https://reviews.llvm.org/D90533