[PATCH] D89670: [clangd] Store the containing symbol for refs

Sat Oct 31 23:32:17 PDT 2020

nridge added inline comments.

================
Comment at: clang-tools-extra/clangd/index/Ref.h:91
   RefKind Kind = RefKind::Unknown;
+  SymbolID Container;
 };
----------------
kadircet wrote:
> i am afraid we are going to have an indeterminate value here if for whatever reason `Container` detection fails. (e.g. for macros, or if ASTNode.Parent set to nullptr by libindex).
> 
> Sent out https://reviews.llvm.org/D90397 to address the issue.
Good catch, and thank you for addressing this!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89670/new/

https://reviews.llvm.org/D89670