[PATCH] D90397: [clangd] Value initialize SymbolIDs

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 31 15:58:39 PDT 2020


nridge added a comment.

Would it have been possible to disallow default-constructing `SymbolID` altogether, and preserve the ability to represent "an always-valid symbol id" (`SymbolID`) vs. "a maybe-valid symbol id" (`Optional<SymbolID>`) as distinct types in the type system?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90397/new/

https://reviews.llvm.org/D90397



More information about the cfe-commits mailing list