[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 31 13:15:59 PDT 2020


sammccall added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:389
   case NodeKind::ParameterDeclarationList:
+  case NodeKind::DeclaratorList:
     return clang::tok::comma;
----------------
OK, this is not *quite* NFC:
 - before this patch, `List::classof(DeclaratorList*)` incorrectly returned false ,now it's true...
 - ...which uncovered these unhandled cases

I'll split these changes into another patch and land that first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90540/new/

https://reviews.llvm.org/D90540



More information about the cfe-commits mailing list