[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 31 09:52:57 PDT 2020


MyDeveloperDay added a comment.

@dmikis  just for history sake I introduce the frontEnd when doing D68554: [clang-format] Proposal for clang-format to give compiler style warnings <https://reviews.llvm.org/D68554>, D69854: [clang-format] [RELAND] Remove the dependency on frontend <https://reviews.llvm.org/D69854> was an attempt to remove the need for frontEnd while doing the same thing, so its not fair to say that D69854 <https://reviews.llvm.org/D69854>
 was the cause of a regression its actually my belief that it would have failed before (unless I'm mistaken)

Having said that I understand what you are trying to do...and agree it being move to libBasic would help us here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90121/new/

https://reviews.llvm.org/D90121



More information about the cfe-commits mailing list