[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

[Douglas Chen via Phabricator via cfe-commits]

dougpuob updated this revision to Diff 302086.
dougpuob added a comment.

- Removed clearAll() function and made the `HPOption` variable passing by value(origin is std::move()).
- Moved static HNOption variable from static getNamingStyles() function to IdentifierNamingCheck class a private data member.
- Replaced auto keyword with explicit std::string.
- Elided braces around single-line.
- Used CXXRecordDecl::isAbstract() directly.
- changed `const auto` to `const auto *` for pointer objects.
- Enhanced test case for enum with two EnumConstant decls.
- Removed unnecessary clang:: namespace for variables.
- Executed `arc lint`
- Final changes.
- Executed `arc lint`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86671/new/

https://reviews.llvm.org/D86671

Files:
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
  clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-notation-cfgfile.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-notation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86671.302086.patch
Type: text/x-patch
Size: 177052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201031/fbd4c367/attachment-0001.bin>