[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

dmajor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 30 18:35:10 PDT 2020


dmajor added a comment.

After 10f2a0d662d8 <https://reviews.llvm.org/rG10f2a0d662d8d72eaac48d3e9b31ca8dc90df5a4> our self-host PGO builds are hitting:
llvm::BranchProbability::getBranchProbability(uint64_t, uint64_t): Assertion `Numerator <= Denominator && "Probability cannot be bigger than 1!"' failed.

https://treeherder.mozilla.org/logviewer?job_id=320324631&repo=try&lineNumber=52597 has the log as well as the .cpp/.sh reproducers, but I assume you'd also need the merged.profdata file, and our bots haven't been taught to save those. I can try to add that ability next week if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88609/new/

https://reviews.llvm.org/D88609



More information about the cfe-commits mailing list