[clang-tools-extra] 8a28a29 - [clang-tidy][test] Fix test failure when LLVM_ENABLE_WERROR is set.

Nathan James via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 30 16:17:28 PDT 2020


Author: Nathan James
Date: 2020-10-30T23:17:11Z
New Revision: 8a28a29c736e6ae88c86a8687e61a62b41e1c430

URL: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430
DIFF: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430.diff

LOG: [clang-tidy][test] Fix test failure when LLVM_ENABLE_WERROR is set.

After https://reviews.llvm.org/D80531 landed, a subtle bug was introduced where the test would fail if `LLVM_ENABLE_WERROR` was set. This just silences that error so the test case runs correctly, down the line it may be worth not enabling `-Werror` for clang-tidy tests even if the cmake flag is passed.

Added: 
    

Modified: 
    clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp
index 50b0c57d3b52..ac9a289129f6 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp
@@ -16,12 +16,12 @@
 // RUN: clang-tidy %s -checks="-*,modernize-replace-disallow-copy-and-assign-macro" \
 // RUN:   -config="{CheckOptions: [ \
 // RUN:    {key: modernize-replace-disallow-copy-and-assign-macro.MacroName, \
-// RUN:     value: DISALLOW_COPY_AND_ASSIGN_MORE_AGUMENTS}]}" | count 0
+// RUN:     value: DISALLOW_COPY_AND_ASSIGN_MORE_AGUMENTS}]}" -- -Wno-extra-semi | count 0
 
 // RUN: clang-tidy %s -checks="-*,modernize-replace-disallow-copy-and-assign-macro" \
 // RUN:   -config="{CheckOptions: [ \
 // RUN:    {key: modernize-replace-disallow-copy-and-assign-macro.MacroName, \
-// RUN:     value: DISALLOW_COPY_AND_ASSIGN_NEEDS_PREEXPANSION}]}" | count 0
+// RUN:     value: DISALLOW_COPY_AND_ASSIGN_NEEDS_PREEXPANSION}]}" -- -Wno-extra-semi | count 0
 
 // Note: the last two tests expect no diagnostics, but FileCheck cannot handle
 // that, hence the use of | count 0.


        


More information about the cfe-commits mailing list