[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith created this revision.
dexonsmith added reviewers: arphaman, JDevlieghere.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.

Push `FileEntryRef` and `DirectoryEntryRef` further, using it them
`Module::Umbrella`, `Module::Header::Entry`, and
`Module::DirectoryName::Entry`.

- Add `DirectoryEntryRef::operator const DirectoryEntry *` and `OptionalDirectoryEntryRefDegradesToDirectoryEntryPtr`, to get the same "degrades to `DirectoryEntry*` behaviour `FileEntryRef` enjoys (this avoids a bunch of churn in various clang tools).
- Leave behind FIXMEs in `Module::Header`, `Module::DirectoryName`, and `UmbrellaAsWritten`. I suspect the `...AsWritten` names aren't needed anymore, but there could be something subtle so I'd rather remove them in a separate follow-up commit.
- Fix the `DirectoryEntryRef` constructor from `MapEntry` to take it by `const&`.


https://reviews.llvm.org/D90497

Files:
  clang/include/clang/Basic/DirectoryEntry.h
  clang/include/clang/Basic/FileEntry.h
  clang/lib/Basic/FileManager.cpp
  clang/unittests/Basic/FileEntryTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90497.302012.patch
Type: text/x-patch
Size: 18505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201030/99012bce/attachment-0001.bin>