[PATCH] D90419: [AMDGPU] Add gfx90c target

Scott Linder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 30 12:07:49 PDT 2020


scott.linder added inline comments.


================
Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:161
 
 # RUN: yaml2obj --docnum=41 %s > %t.o.41
 # RUN: llvm-readobj -s -file-headers %t.o.41 | FileCheck --check-prefixes=ELF-ALL,ELF-GFX1031 %s
----------------
Heads up, I just landed a refactor of this file in https://reviews.llvm.org/D90245

It would probably be easiest to just start from the existing test, and copy-paste following the pattern. The RUN lines can now be in GFX# order, you don't need to create a new YAML document, and the tests are grouped by GFX#


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90419/new/

https://reviews.llvm.org/D90419



More information about the cfe-commits mailing list