[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 30 08:30:12 PDT 2020
kadircet marked 2 inline comments as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:170
+ [PathMatch(std::move(PathMatch)),
+ FragmentDir(FragmentDirectory)](const Params &P) {
if (P.Path.empty())
----------------
sammccall wrote:
> nit: why the rename rather than just capturing?
because it is actually a member of FragmentCompiler and not a scoped variable :/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90270/new/
https://reviews.llvm.org/D90270
More information about the cfe-commits
mailing list