[PATCH] D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file.
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 30 04:08:46 PDT 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:329-330
+
+ if (!ConfigFile.empty()) {
+ if (!Config.empty()) {
+ llvm::errs() << "Error: --config-file and --config are "
----------------
nit: Should we be using `Config(File)?.getNumOccurances() > 0` here and below
If someone puts `--config=""` They are specifying a config(file)?, even if its empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89936/new/
https://reviews.llvm.org/D89936
More information about the cfe-commits
mailing list