[clang] 772adb7 - [NFC] Don't run python binding tests with sanitizers

Vitaly Buka via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 23:48:17 PDT 2020


Author: Vitaly Buka
Date: 2020-10-29T23:48:08-07:00
New Revision: 772adb7d9b80ffc3c6fe48ab6ef76d2238e51969

URL: https://github.com/llvm/llvm-project/commit/772adb7d9b80ffc3c6fe48ab6ef76d2238e51969
DIFF: https://github.com/llvm/llvm-project/commit/772adb7d9b80ffc3c6fe48ab6ef76d2238e51969.diff

LOG: [NFC] Don't run python binding tests with sanitizers

Almost any sanitizer can try to install interceptors.

Added: 
    

Modified: 
    clang/bindings/python/tests/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/bindings/python/tests/CMakeLists.txt b/clang/bindings/python/tests/CMakeLists.txt
index 46dafa57dea1..280da9d00686 100644
--- a/clang/bindings/python/tests/CMakeLists.txt
+++ b/clang/bindings/python/tests/CMakeLists.txt
@@ -15,13 +15,13 @@ if(NOT LLVM_ENABLE_PIC)
   set(RUN_PYTHON_TESTS FALSE)
 endif()
 
-# Do not try to run if libclang was built with ASan/MSan because
+# Do not try to run if libclang was built with sanitizers because
 # the sanitizer library will likely be loaded too late to perform
 # interception and will then fail.
 # We could use LD_PRELOAD/DYLD_INSERT_LIBRARIES but this isn't
 # portable so its easier just to not run the tests when building
 # with ASan.
-if(LLVM_USE_SANITIZER MATCHES ".*(Memory|Address).*")
+if(NOT LLVM_USE_SANITIZER STREQUAL "")
   set(RUN_PYTHON_TESTS FALSE)
 endif()
 


        


More information about the cfe-commits mailing list