[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 18:01:57 PDT 2020


aeubanks added a comment.

I'm more convinced now that my initial direction was the cleanest way. It would simplify users of `PassBuilder` quite a bit.

I don't want to include PassManager.h into TargetMachine.h just to get `PassBuilder::OptimizationLevel`, so either we could factor out `OptimizationLevel` into its own header file so that we can pass an `OptimizationLevel` to `TargetMachine::registerPassBuilderCallbacks`, or we could just pass a `OnlyAddRequiredPasses` bool to `TargetMachine::registerPassBuilderCallbacks`. But either way, that can happen in a future change when the need arises (such as when we implement `AMDGPUTargetMachine::registerPassBuilderCallbacks`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89158/new/

https://reviews.llvm.org/D89158



More information about the cfe-commits mailing list