[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

Thu Oct 29 13:23:59 PDT 2020

erichkeane added inline comments.

================
Comment at: clang/include/clang/AST/DeclCXX.h:1013
   CXXMethodDecl *getLambdaStaticInvoker() const;
+  CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const;
+
----------------
erichkeane wrote:
> rjmccall wrote:
> > Probably worth clarifying in the comment which invoker is returned by the no-arguments variant.
> I just looked and the first is actually only used 1x!  I think I can just replace that usage and remove the former overload if that is acceptable to you.
On second thought... I might leave this alone.  Otherwise the ItaniumMangler basically needs to reproduce the functionality.  I think the improved comment is an appropriate change here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89559/new/

https://reviews.llvm.org/D89559