[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

Melanie Blower via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 12:23:07 PDT 2020


mibintc marked 2 inline comments as done.
mibintc added inline comments.


================
Comment at: clang/lib/Parse/ParsePragma.cpp:2967
+    PP.Diag(Tok.getLocation(), diag::warn_pragma_fp_ignored)
+        << PragmaName.getIdentifierInfo()->getName();
+    return;
----------------
aaron.ballman wrote:
> Can you pass in `PragmaName` directly, or does that do unfortunate things with single quotes?
After I changed it to PragmaName, the clang-format didn't find anything to fix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90316/new/

https://reviews.llvm.org/D90316



More information about the cfe-commits mailing list