[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723
+  bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() ||
+               Ty->isAggregateType();
   bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64;
----------------
I suspect this code doesn't handle C++ member pointers correctly.  But maybe we can leave that for a followup.

Could we simplify this to `bool isInt = !Ty->isFloatingType();`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90329/new/

https://reviews.llvm.org/D90329