[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

[Cullen Rhodes via Phabricator via cfe-commits]

c-rhodes marked 2 inline comments as done.
c-rhodes added a comment.

In D88233#2359022 <https://reviews.llvm.org/D88233#2359022>, @fpetrogalli wrote:

> Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor stuff.
>
> In the commit message:
>
>> Arm C Language Extensions (ACLE, version 00bet5, section 3.7.3.3) for SVE [1].
>
> It seems that a reference to [1] is missing:  https://developer.arm.com/documentation/100987/latest
> Also, please note that the current version is 00bet6. Nothing seem to have changed from 00bet5 to 00bet6 in terms of this patch, but I think it is worth keeping it up to date with the specs numbering until it is merged into master.
>
> Please fix the commit message before submitting.

I didn't realise 00bet6 had been released, thanks for pointing that out.

Thanks for reviewing!



================
Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:141-158
+  ss8 = ss8 + fs8; // expected-error {{cannot combine fixed-length and sizeless SVE vectors in expression, result is ambiguous}}
+  ss8 = ss8 + gs8; // expected-error {{cannot combine GNU and SVE vectors in expression, result is ambiguous}}
+
+  fs8 = fs8 + ss8; // expected-error {{cannot combine fixed-length and sizeless SVE vectors in expression, result is ambiguous}}
+  fs8 = fs8 + gs8; // expected-error {{cannot combine GNU and SVE vectors in expression, result is ambiguous}}
+
+  gs8 = gs8 + ss8; // expected-error {{cannot combine GNU and SVE vectors in expression, result is ambiguous}}
----------------
fpetrogalli wrote:
> Nit: should you test more binary operators other than just `+`, like you have done for the vector initialization tests?
> Nit: should you test more binary operators other than just +, like you have done for the vector initialization tests?

Added tests for a couple more operators.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88233/new/

https://reviews.llvm.org/D88233