[PATCH] D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file.

Dmitry Polukhin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 03:13:02 PDT 2020


DmitryPolukhin added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337
+
+    Config.assign((*Text)->getBuffer());
+  }
----------------
DmitryPolukhin wrote:
> I suggest creating new local variable with text of the config from `Config` or `ConfigFile` file content i.e. avoid modifying `Config` itself.
It doesn't compile and using local variable instead of changing command line option will make this code easier to read and understand:
```
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:334:12: error: no matching member function for call to 'assign'
    Config.assign((*Text)->getBuffer());
    ~~~~~~~^~~~~~
```
Could you please fix build and please upload diff with `arc diff` as @njames93 suggested so buildbot can test your changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89936/new/

https://reviews.llvm.org/D89936



More information about the cfe-commits mailing list