[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:162
               return false;
+            llvm::StringRef Path = P.Path;
+            // Ignore the file if it is not nested under Fragment and strip the
----------------
sammccall wrote:
> maybe pull out a method `Optional<StringRef> configRelative(StringRef)`?
> This would avoid the duplication
Went with just `StringRef` as otuput and made empty imply a missmatch (i.e. being out-of-tree)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90270/new/

https://reviews.llvm.org/D90270