[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 14:18:18 PDT 2020


nickdesaulniers added a comment.

> It's trivial to not create a new enum value and always pass -stack-protector <N> along

That was incorrect.  Rebasing this on top of D90271 <https://reviews.llvm.org/D90271> causes 49 test failures, because the diff I posted above didn't actually remove the new enum or changes to clang/lib/Frontend/CompilerInvocation.cpp.  So I've answered my own question; we should add this enum value.  Let me rebase this differently then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90194/new/

https://reviews.llvm.org/D90194



More information about the cfe-commits mailing list